Skip to content

fix sidebar_position.#770

Open
fujitatomoya wants to merge 3 commits intokubeedge:masterfrom
fujitatomoya:fix-sidebar_position
Open

fix sidebar_position.#770
fujitatomoya wants to merge 3 commits intokubeedge:masterfrom
fujitatomoya:fix-sidebar_position

Conversation

@fujitatomoya
Copy link
Contributor

@fujitatomoya fujitatomoya commented Feb 25, 2026

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:

Fixes #

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

the title should say enough, just fixing up the sidebar_position in doc.

  • What is the current behavior? (You can also link to an open issue here)

mixed up and duplilcated.

  • What is the new behavior (if this is a feature change)?

N.A

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

@gemini-code-assist
Copy link

Summary of Changes

Hello @fujitatomoya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the user experience of the documentation by refining the sidebar navigation. It updates the "sidebar_position" metadata in various markdown files, which dictates their display order in the documentation sidebar. This ensures a more logical and organized presentation of content for readers.

Highlights

  • Documentation Navigation: Adjusted "sidebar_position" values across several documentation markdown files to ensure correct ordering and resolve previous inconsistencies or duplications in the sidebar navigation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docs/advanced/admission.md
    • Added "sidebar_position: 1".
  • docs/advanced/edgesite.md
    • Added "sidebar_position: 11".
  • docs/advanced/hold_and_release.md
    • Changed "sidebar_position" from 4 to 9.
  • docs/advanced/metrics.md
    • Changed "sidebar_position" from 4 to 6.
  • docs/advanced/servicebus.md
    • Added "sidebar_position: 10".
  • docs/developer/dmi.md
    • Changed "sidebar_position" from 1 to 3.
  • docs/developer/mapper-framework.md
    • Changed "sidebar_position" from 1 to 12.
  • docs/developer/mappers/index.md
    • Added "sidebar_position: 1".
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 25, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sidebar_position metadata in several documentation files across the docs/advanced and docs/developer directories. The changes resolve issues with duplicated and incorrect sidebar positions, ensuring a logical and consistent ordering of documents in the sidebar. The modifications consist of adding or adjusting the sidebar_position values in the frontmatter of the respective markdown files.

Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# File Before After Issue
1 admission.md MISSING 1 No sidebar_position
2 metrics.md 4 6 Duplicate (pos 4)
3 hold_and_release.md 4 9 Duplicate (pos 4)
4 servicebus.md MISSING 10 No sidebar_position
5 edgesite.md MISSING 11 No sidebar_position
6 dmi.md 1 3 Duplicate (pos 1)
7 mapper-framework.md 1 12 Duplicate (pos 1)
8 index.md MISSING 1 No sidebar_position

Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help fix sidebar_position in Chinease docs?

@fujitatomoya
Copy link
Contributor Author

@Shelley-BaoYue sure things, and done.

File (i18n/zh) Change
admission.md Added sidebar_position: 1
edgesite.md Added sidebar_position: 11
metrics.md Changed sidebar_position: 46
servicebus.md Added sidebar_position: 10
developer/dmi.md Changed sidebar_position: 13
developer/mapper-framework.md Changed sidebar_position: 112
index.md Added sidebar_position: 1

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fix-sidebar_position branch from f5f6b3c to 83dee06 Compare March 2, 2026 23:33
@fujitatomoya
Copy link
Contributor Author

@Shelley-BaoYue also rebase has been done.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fujitatomoya after the PR has been reviewed.
You can assign the PR to them by writing /assign @fujitatomoya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fujitatomoya
Copy link
Contributor Author

@Shelley-BaoYue is this good to go?

Copy link
Collaborator

@kubeedge-bot kubeedge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot kubeedge-bot self-assigned this Mar 9, 2026
@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants