-
Notifications
You must be signed in to change notification settings - Fork 8
Support TFJob v1beta1 crd validation #1
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @Jeffwan. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
|
@gaocegege Hi, could you help take a look at this change? |
|
Hi, thanks for your contribution. While I think the repo is not ready to produce validation for our API becasue it does not support map. Thus we should wait until k8s supports validation feature for map field. |
|
Thanks. @gaocegege What's your suggestion? Should I close this PR? What I need is the validation process during tfjob creation. Otherwise, it's hard for entry users to detect errors from tfcontroller. Do you have any suggestion? |
|
I think we could keep sync with k8s community and wait until k8s supports validation feature for map field. Currently, we have to export errors in the runtime instead of ahead of time. I do not have a better solution. |
|
Thanks @gaocegege I will temporarily leave this PR open and go back to kubernetes side for verification. If k8s has progress on it, we can provide more straightforward messages by enabling map validation |
I am trying to add v1beta1 validation, make schema generation code more generic for all versions.
I am very new to go, I meet issue when I build code. I do think that's the issue from dependency conflicts. Looks like common from
tf-operatoris not compatible withcrd-validation.Could someone tell me how to make the changes in Gopkg.toml?
This change is