fix(async-upload): add TLS and auth config for base image pull on disconnected clusters#2665
Open
jonburdo wants to merge 1 commit intokubeflow:mainfrom
Open
Conversation
…connected clusters The async upload job only passed push_args to skopeo for the destination registry, but the base image pull (e.g. busybox for ModelCar) had no TLS or auth configuration. This caused failures on disconnected clusters where the base image is mirrored to a registry with self-signed certs or requiring authentication. Add two new independent config flags for the base image pull: - MODEL_SYNC_DESTINATION_OCI_BASE_IMAGE_TLS_VERIFY (default: true) - MODEL_SYNC_DESTINATION_OCI_BASE_IMAGE_CREDENTIALS_PATH (default: none) Ref: RHOAIENG-60454 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jon Burdo <jon@jonburdo.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async upload job only passed push_args to skopeo for the destination registry, but the base image pull (e.g. busybox for ModelCar) had no TLS or auth configuration. This caused failures on disconnected clusters where the base image is mirrored to a registry with self-signed certs or requiring authentication.
Add two new independent config flags for the base image pull:
Ref: RHOAIENG-60454
Description
How Has This Been Tested?
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes