Skip to content

Fix the model type selector when the model type is unknown#2676

Open
ppadti wants to merge 1 commit intokubeflow:mainfrom
ppadti:unknown-model-type
Open

Fix the model type selector when the model type is unknown#2676
ppadti wants to merge 1 commit intokubeflow:mainfrom
ppadti:unknown-model-type

Conversation

@ppadti
Copy link
Copy Markdown
Contributor

@ppadti ppadti commented May 5, 2026

Description

This PR aims to fix the register flow from model catalog when the model type is unknown.
before:
Screenshot 2026-05-05 at 4 40 05 PM

after:
Screenshot 2026-05-05 at 4 37 16 PM

How Has This Been Tested?

To test in mock mode:
Update the static_mock_data.go file to have model_type as unknown and check the register flow from catalog.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: ppadti <ppadti@redhat.com>
@google-oss-prow google-oss-prow Bot requested review from chambridge and fege May 5, 2026 11:11
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ppadti. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions Bot added Area/UI and removed size/M labels May 5, 2026
@Philip-Carneiro
Copy link
Copy Markdown
Contributor

/lgtm

@google-oss-prow
Copy link
Copy Markdown
Contributor

@Philip-Carneiro: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants