Fix the model type selector when the model type is unknown#2676
Open
ppadti wants to merge 1 commit intokubeflow:mainfrom
Open
Fix the model type selector when the model type is unknown#2676ppadti wants to merge 1 commit intokubeflow:mainfrom
ppadti wants to merge 1 commit intokubeflow:mainfrom
Conversation
Signed-off-by: ppadti <ppadti@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
Contributor
|
@Philip-Carneiro: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the register flow from model catalog when the model type is unknown.

before:
after:

How Has This Been Tested?
To test in mock mode:
Update the static_mock_data.go file to have model_type as unknown and check the register flow from catalog.
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes