fix(ci): quote output in repeat_cmd_until to prevent flaky E2E deploys

[manaswinidas]

Description

Fixes a flaky E2E test failure in the "Deploy Model Registry using manifests" step.

During a deployment rollout, when multiple pods temporarily co-exist with different images, the repeat_cmd_until function in scripts/utils.sh receives multi-value output from the jsonpath query (e.g., two image names separated by a newline). The unquoted $output in the [ ] test expands to multiple words, causing a [: too many arguments error. This makes the condition never succeed, so the deploy step spins for the full 500-second timeout before failing.

Fix: Switch from [ $output $condition ] to [[ "$output" $condition ]], which properly handles multi-word values.

Example of the failure (from this CI run, attempt 1):

+ output='ghcr.io/kubeflow/model-registry/server:latest
ghcr.io/kubeflow/model-registry:main-'
+ '[' ghcr.io/kubeflow/model-registry/server:latest ghcr.io/kubeflow/model-registry:main- = ghcr.io/kubeflow/model-registry:main- ']'
././scripts/utils.sh: line 29: [: too many arguments

How Has This Been Tested?

Verified the shell behavior locally:

# Before (fails with multi-word output):
output="val1 val2"; [ $output = val2 ]   # => bash: [: too many arguments

# After (works correctly):
output="val1 val2"; [[ "$output" = val2 ]]  # => no error, evaluates to false as expected

Test Impact

No new tests needed — this fixes CI infrastructure flakiness, not application code.

Assisted-by: Claude (Anthropic)

Made with Cursor

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment