-
Notifications
You must be signed in to change notification settings - Fork 65
test(tb): Migrate TBC test-related workflows from kubeflow/kubeflow to notebooks-v1 branch #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: notebooks-v1
Are you sure you want to change the base?
Conversation
- tb_controller_multi_arch_test.yaml - tb_controller_integration_test.yaml migrate the files above to kubeflow/notebooks-v1 branch added the following needed for the tests: - install_cert_manager.sh - install_istio.sh - install_kind.sh - install_kustomize.sh - kind-1-22.yaml - kind-1-25.yaml Signed-off-by: IlyaShav <ilya.shavkonov@nokia.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributions - changes I am requesting are hopefully obvious/straightforward...
also please be aware - depending on which notebooks-v1
workflow PR is ready to merge first - we may also need a rebase as some of the testing/gh-actions
files are also being created in additional PRs being raised.
Co-authored-by: Andy Stoneberg <andyatmiami@users.noreply.github.com> Signed-off-by: ishavkon <ishavkon@redhat.com>
Co-authored-by: Andy Stoneberg <andyatmiami@users.noreply.github.com> Signed-off-by: ishavkon <ishavkon@redhat.com>
Co-authored-by: Andy Stoneberg <andyatmiami@users.noreply.github.com> Signed-off-by: ishavkon <ishavkon@redhat.com>
it is not referenced, thus will be deleted. Signed-off-by: ishavkon <ishavkon@redhat.com>
change master branch to main. Signed-off-by: ishavkon <ishavkon@redhat.com>
…tests. Signed-off-by: IlyaShav <ilya.shavkonov@nokia.com>
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your continued engagement.. getting closer to having something merge-able.. but still need to do a little more refining.
Please reach out to me if you need/want more details about how you can test this on your fork to gain confidence in its functionality on the upstream repo.
I will be testing the changes on my own fork. Signed-off-by: ishavkon <ishavkon@redhat.com>
- install_kustomize.sh - install_kind.sh - install_istio.sh - install_cert_manager.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your continued attention to this PR... just a couple more things to clear up..
- please ensure the DCO checks on your PR are passing.. you can probably squash some/all of your commits if you want to avoid having to make sure each one is signed
- fix up the indenting that was introduced (i'm guessing unintentionally) to
kind-1-25.yaml
- |- | ||
[plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"] | ||
endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you introduced an indentation here that was not present in the source originally:
Preserving original formatting will avoid a merge conflict if/as some other PR that includes this file gets merged first.
- |- | |
[plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"] | |
endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"] | |
- |- | |
[plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"] | |
endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"] |
nodes: | ||
- role: control-plane | ||
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1 | ||
- role: worker | ||
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1 No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you introduced an indentation here that was not present in the source originally:
Preserving original formatting will avoid a merge conflict if/as some other PR that includes this file gets merged first.
nodes: | |
- role: control-plane | |
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1 | |
- role: worker | |
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1 | |
nodes: | |
- role: control-plane | |
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1 | |
- role: worker | |
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1 |
resolves #591
migrate the files below to kubeflow/notebooks-v1 branch:
added the following needed for the tests: