Skip to content

Conversation

ishavkon
Copy link

@ishavkon ishavkon commented Sep 18, 2025

resolves #591

migrate the files below to kubeflow/notebooks-v1 branch:

  • tb_controller_multi_arch_test.yaml
  • tb_controller_integration_test.yaml

added the following needed for the tests:

  • install_cert_manager.sh
  • install_istio.sh
  • install_kind.sh
  • install_kustomize.sh
  • kind-1-25.yaml

 - tb_controller_multi_arch_test.yaml
 - tb_controller_integration_test.yaml
 migrate the files above to kubeflow/notebooks-v1 branch

 added the following needed for the tests:
 - install_cert_manager.sh
 - install_istio.sh
 - install_kind.sh
 - install_kustomize.sh
 - kind-1-22.yaml
 - kind-1-25.yaml

Signed-off-by: IlyaShav <ilya.shavkonov@nokia.com>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/ci area - related to ci label Sep 18, 2025
Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions - changes I am requesting are hopefully obvious/straightforward...

also please be aware - depending on which notebooks-v1 workflow PR is ready to merge first - we may also need a rebase as some of the testing/gh-actions files are also being created in additional PRs being raised.

ishavkon and others added 6 commits September 22, 2025 10:30
Co-authored-by: Andy Stoneberg <andyatmiami@users.noreply.github.com>
Signed-off-by: ishavkon <ishavkon@redhat.com>
Co-authored-by: Andy Stoneberg <andyatmiami@users.noreply.github.com>
Signed-off-by: ishavkon <ishavkon@redhat.com>
Co-authored-by: Andy Stoneberg <andyatmiami@users.noreply.github.com>
Signed-off-by: ishavkon <ishavkon@redhat.com>
it is not referenced, thus will be deleted.

Signed-off-by: ishavkon <ishavkon@redhat.com>
change master branch to main.

Signed-off-by: ishavkon <ishavkon@redhat.com>
…tests.

Signed-off-by: IlyaShav <ilya.shavkonov@nokia.com>
@google-oss-prow google-oss-prow bot added area/controller area - related to controller components area/v1 area - version - kubeflow notebooks v1 labels Sep 22, 2025
@andyatmiami
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continued engagement.. getting closer to having something merge-able.. but still need to do a little more refining.

Please reach out to me if you need/want more details about how you can test this on your fork to gain confidence in its functionality on the upstream repo.

ishavkon and others added 3 commits September 28, 2025 11:22
I will be testing the changes on my own fork.

Signed-off-by: ishavkon <ishavkon@redhat.com>
 - install_kustomize.sh
 - install_kind.sh
 - install_istio.sh
 - install_cert_manager.sh
Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your continued attention to this PR... just a couple more things to clear up..

  • please ensure the DCO checks on your PR are passing.. you can probably squash some/all of your commits if you want to avoid having to make sure each one is signed
  • fix up the indenting that was introduced (i'm guessing unintentionally) to kind-1-25.yaml

Comment on lines +5 to +7
- |-
[plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"]
endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"]
Copy link
Contributor

@andyatmiami andyatmiami Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you introduced an indentation here that was not present in the source originally:

Preserving original formatting will avoid a merge conflict if/as some other PR that includes this file gets merged first.

Suggested change
- |-
[plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"]
endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"]
- |-
[plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"]
endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"]

Comment on lines +20 to +24
nodes:
- role: control-plane
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1
- role: worker
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1 No newline at end of file
Copy link
Contributor

@andyatmiami andyatmiami Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you introduced an indentation here that was not present in the source originally:

Preserving original formatting will avoid a merge conflict if/as some other PR that includes this file gets merged first.

Suggested change
nodes:
- role: control-plane
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1
- role: worker
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1
nodes:
- role: control-plane
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1
- role: worker
image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area - related to ci area/controller area - related to controller components area/v1 area - version - kubeflow notebooks v1 ok-to-test size/L
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants