feat: Migrate TWA test-related workflows #627
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yehudit1987
force-pushed
the
feat/migrate_twa_tests
branch
3 times, most recently
from
01e48e4 to
a5bfa91
Compare
google-oss-prow
bot
added
area/backend
yehudit1987
force-pushed
the
feat/migrate_twa_tests
branch
3 times, most recently
from
8b9b78f to
28f1111
Compare
andyatmiami
suggested changes
Oct 6, 2025
There was a problem hiding this comment.
Really nice investigations/implementations here @yehudit1987 - but for the immediate needs of notebooks-v1 migration - I would prefer we dial back some of these changes to align more with the "status quo" of how kubeflow/kubeflow implemented these workflows.
yehudit1987
force-pushed
the
feat/migrate_twa_tests
branch
2 times, most recently
from
2615d17 to
a97625b
Compare
Signed-off-by: Yehudit Kerido <yehudit1987@gmail.com>
yehudit1987
force-pushed
the
feat/migrate_twa_tests
branch
from
a97625b to
09f01c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate frontend tests, multi-arch build, and integration test workflows
Optimize during migration:
• Add npm and Docker build caching for 40-50% faster builds
• Eliminate code duplication by centralizing common library build
• Replace manual multi-arch builds with docker/build-push-action
• Standardize naming conventions and make scripts executable
Resolve issue [TASK] Migrate TWA test-related workflows from kubeflow/kubeflow to notebooks-v1 branch #589