Add configuration to block on node labels #1215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new configuration setting to be able to block reboots on nodes that have matching labels applied, similar to the pod selector and annotation locking. The user can specify one or more `--block-node-label` parameters, using the same kubectl label selector format to match and block on whether a label is present (e.g. `my.custom.label`) or if the label is set to a specific value (e.g. `my.custom.label:block-reboots`). Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Collaborator
|
Would you mind writing about your use case? I would like to have it on the record. This is for history's sake :) I think it's also worth doing an e2e test, this way v2 will not break this workflow. |
|
This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days). |
evrardjp
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes adding a new configuration setting to be able to block reboots on nodes that have matching labels applied, similar to the pod selector and annotation locking.
The user can specify one or more
--block-node-labelparameters, using the same kubectl label selector format to match and block on whether a label is present (e.g.my.custom.label) or if the label is set to a specific value (e.g.my.custom.label:block-reboots).