docs: add SubnetDiscoveryByReachability feature gate to values.yaml and feature-gates table #4331
+18
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When creating an ALB without specifying subnets and without providing the annotation
alb.ingress.kubernetes.io/subnets
,the controller still automatically discovers and attaches subnets — even though those subnets are not tagged with
kubernetes.io/cluster/${cluster-name}
.This behavior comes from the
SubnetDiscoveryByReachability
feature gate, but it is not currently listed invalues.yaml
or the feature-gates documentation table.Description
This PR improves documentation and visibility of supported feature gates:
values.yaml:
Added a commented-out entry under
controllerConfig.featureGates
forSubnetDiscoveryByReachability
.This makes it easier for users to discover and configure this option directly in values without having to dig into the docs.
Feature Gates Table:
Added a new row for
SubnetDiscoveryByReachability
that explains how the controller automatically classifies subnets as public or private based on their route table configuration.This ensures consistency and parity with the actual supported feature gates.
These changes are purely documentation/UX improvements and do not modify any controller logic.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯