feat: Support configure target-group-attributes for different service port #4326 #4338
+215
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1234
Description
This PR introduces the ability to configure target group attributes for specific ports in Network Load Balancers (NLB). Previously, target group attributes were applied uniformly across all ports in a service. With this change, users can now specify different attributes for different ports, providing more granular control over target group behavior.
Key changes:
• Added support for port-specific target group attributes using the format
service.beta.kubernetes.io/aws-load-balancer-target-group-attributes.{port}
• Maintained backward compatibility with existing
service.beta.kubernetes.io/aws-load-balancer-target-group-attributes
annotation• Port-specific attributes override the default attributes when specified
• Empty values in port-specific attributes don't override global values, allowing selective attribute inheritance
Example usage:
Note: When a port-specific attribute has an empty value, it will not override the global attribute value. This allows you to selectively inherit global values while overriding others.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯