Skip to content

fix(conformance): change InferencePoolInvalidEPPService test to align with spec . #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2025
Merged

fix(conformance): change InferencePoolInvalidEPPService test to align with spec . #1061

merged 5 commits into from
Jul 2, 2025
+36 −18

Conversation

zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Jun 25, 2025 •
edited
Loading

conformance test caseInferencePoolInvalidEPPService update to align with #1070:

  1. checking the inferencePool's condition contains ResolvedRefs to status:false when the EPP is invalid.
  2. when EPP is invalid, it's only check the response's statusCode is 500, however in the spec we can allow any response with 5XX. (source)

cc: @aslakknutsen

@netlify Netlify
Copy link

netlify bot commented Jun 25, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 9bdeb97
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6863f92f6924e30008fb4c09
😎 Deploy Preview https://deploy-preview-1061--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zetxqx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2025
@zetxqx zetxqx changed the title fix(conformance): make InferencePoolInvalidEPPService stick to the API spec. [WIP] fix(conformance): make InferencePoolInvalidEPPService stick to the API spec. Jun 25, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2025
@robscott
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2025
@zetxqx zetxqx changed the title [WIP] fix(conformance): make InferencePoolInvalidEPPService stick to the API spec. fix(conformance): make InferencePoolInvalidEPPService stick to the API spec. Jun 25, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Jun 25, 2025 •
edited
Loading

updated the API spec and refine the test.

Now both GKE-gateway and istio are failing the test but this is expected.

cc: @aslakknutsen

@zetxqx zetxqx changed the title fix(conformance): make InferencePoolInvalidEPPService stick to the API spec. feat(api + conformance): update the API spec and change InferencePoolInvalidEPPService test accordingly . Jun 25, 2025
robscott
robscott reviewed Jun 25, 2025
View reviewed changes
@zetxqx zetxqx changed the title feat(api + conformance): update the API spec and change InferencePoolInvalidEPPService test accordingly . fix(conformance): change InferencePoolInvalidEPPService test to align with spec . Jun 25, 2025
@zetxqx zetxqx mentioned this pull request Jun 26, 2025
Merged
@aslakknutsen aslakknutsen mentioned this pull request Jun 26, 2025
Merged
@zetxqx zetxqx mentioned this pull request Jun 26, 2025
Closed
12 tasks
aslakknutsen
aslakknutsen suggested changes Jun 28, 2025
View reviewed changes
@zetxqx
Copy link
Contributor Author

zetxqx commented Jul 1, 2025

@robscott could you take another look?

@robscott
Copy link
Member

robscott commented Jul 1, 2025

Thanks @zetxqx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2025
@aslakknutsen
Copy link
Contributor

/assign @terrytangyuan

@ahg-g
Copy link
Contributor

ahg-g commented Jul 2, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, aslakknutsen, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@LiorLieberman
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025
@LiorLieberman
Copy link
Member

/unhold

Wrong PR 🥲

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit b558f8f into kubernetes-sigs:main Jul 2, 2025
9 checks passed
EyalPazz pushed a commit to EyalPazz/gateway-api-inference-extension that referenced this pull request Jul 9, 2025
@zetxqx @EyalPazz
fix(conformance): change InferencePoolInvalidEPPService test to align…
81dc0ac 
… with spec . (kubernetes-sigs#1061)

* make InferencePoolInvalidEPPService stick to the API spec.

* reinfe api and test case.

* revert api change to make this PR forcus on conformance test.

* use invalid pool.
@zetxqx zetxqx deleted the eppunavailable branch July 29, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@aslakknutsen aslakknutsen aslakknutsen approved these changes

@kfswain kfswain Awaiting requested review from kfswain

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

@danehans danehans Awaiting requested review from danehans

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

Assignees

@robscott robscott

@terrytangyuan terrytangyuan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zetxqx @k8s-ci-robot @robscott @aslakknutsen @ahg-g @LiorLieberman @terrytangyuan