Promote 4680 to beta

[harche]

• One-line PR description: Promote Add Resource Health Status to the Pod Status for Device Plugin and DRA to beta in 1.35

• Issue link: Add Resource Health Status to the Pod Status for Device Plugin and DRA #4680

• Other comments:

[harche]

/cc @SergeyKanzhelev @haircommander

[ArangoGutierrez]

/lgtm

[SergeyKanzhelev]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArangoGutierrez, harche, mrunalp, SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• keps/prod-readiness/OWNERS
• keps/sig-node/OWNERS [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[harche]

cc @deads2k @johnbelamaric @jpbetz @soltysh @wojtek-t for approval.

[kannon92]

I see this comment from sohankunkerkar.

#4680 (comment)

To promote to beta, it sounds like like these issues all have to be complete.

[kannon92]

• Device Health For Terminated Pods
• Configuration timeouts
  • DRA: Add configurable health check timeout per device kubernetes#133752
• Failure Message Field
  • Add message field support to DRA device health reporting kubernetes#134506

So right now, it seems the Device health for terminated pods is still waiting on an implementation. Is this blocking for beta?

[ArangoGutierrez]

• Device Health For Terminated Pods

• Configuration timeouts

  • DRA: Add configurable health check timeout per device kubernetes#133752

• Failure Message Field

  • Add message field support to DRA device health reporting kubernetes#134506

So right now, it seems the Device health for terminated pods is still waiting on an implementation. Is this blocking for beta?

I am working on a PR for the remaining one, hope to have it by EOD today

[kannon92]

Thank you @ArangoGutierrez and @harche!

As long as it looks reasonable to get this before you flip the gate to true I think that is fine.

[kannon92]

I would ask that you make sure the KEP reflects these requirements. Reading the KEP it isn't clear to me if this is called out.

[jpbetz]

PRR reviewer here.

Can we add one note in to the production readiness section to make it clear that when the feature is disabled, the the values of the fields will be dropped when serving the API even if they are written to storage? This prevents clients from acting on the (stale) data when the feature is off. I realize that when the feature is enabled again that there may be a brief period of time where the stale values reappear before controllers actuate and update the values. My goal is to keep that period as short as possible.

LGTM otherwise.

[harche]

Thanks @kannon92 and @jpbetz for your suggestions.

I have created the PR to update the enhancements with the beta related changes, #5653

cc @ArangoGutierrez @SergeyKanzhelev @haircommander

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[harche]

Thanks @kannon92 and @jpbetz for your suggestions.

I have created the PR to update the enhancements with the beta related changes, #5653

cc @ArangoGutierrez @SergeyKanzhelev @haircommander

Instead of having two different PRs, I merged the change from #5653 in this PR itself.