-
Notifications
You must be signed in to change notification settings - Fork 452
Improve local builds with another buildx builder #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve local builds with another buildx builder #971
Conversation
|
|
|
Welcome @NBardelot! |
Introduces to new parameters in the Makefile: - BUILDX_BUILDER_NAME, allowing to select the builder - BUILDX_BUILDER_SKIP_CREATION, to skip the builder creation when the builder already exists and is not managed by the Makefile
68a2ac7 to
1f1372f
Compare
|
/kind feature |
|
/size S |
thockin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: NBardelot, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Introduces to new parameters in the Makefile:
NOTE : I propose this in parallel of the feature request #970 as I had to make some adaptations locally to be able to build the project, and I think they could be used by others.