Skip to content

feat: add declarative validation WG as a reviewers for staging/src/k8s.io/code-generator/cmd/validation-gen #134467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add declarative validation WG as a reviewers for staging/src/k8s.io/code-generator/cmd/validation-gen #134467

wants to merge 1 commit into from

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Oct 8, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

PR creates an OWNERS file at staging/src/k8s.io/code-generator/cmd/validation-gen/OWNERS and adds aaron-prindle to reviewers. Additional approvers and reviewers are inherited from parent OWNERS.

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aaron-prindle
Once this PR has been reviewed and has the lgtm label, please assign wojtek-t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from sttts and wojtek-t October 8, 2025 02:19
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 8, 2025
@aaron-prindle aaron-prindle force-pushed the dv-owners branch 2 times, most recently from d1da9bc to d9052e2 Compare October 8, 2025 02:20
@aaron-prindle
Copy link
Contributor Author

/cc @jpbetz

/sig api-machinery

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz October 8, 2025 02:20
jpbetz
jpbetz reviewed Oct 8, 2025
View reviewed changes
staging/src/k8s.io/code-generator/cmd/validation-gen/OWNERS

# Additional reviewers are inherited from parent OWNERS
reviewers:
- aaron-prindle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this. Would you also add @yongruilin and @lalitc375?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, they are added now

@aaron-prindle aaron-prindle force-pushed the dv-owners branch 2 times, most recently from e37ae05 to 8b840a5 Compare October 8, 2025 19:57
@aaron-prindle aaron-prindle changed the title feat: add aaron-prindle as a reviewer for staging/src/k8s.io/code-generator/cmd/validation-gen feat: add declarative validation WG as a reviewers for staging/src/k8s.io/code-generator/cmd/validation-gen Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

@aaron-prindle: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce f43f5a0 link true /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

1 more reviewer

@jpbetz jpbetz jpbetz left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaron-prindle @k8s-ci-robot @jpbetz