Skip to content

feat: Support configuring rule.Reason as a Sprintf format string #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Support configuring rule.Reason as a Sprintf format string #1068

wants to merge 2 commits into from

Conversation

jessehu
Copy link

@jessehu jessehu commented Jun 11, 2025

So we can define one templated Reason to generate many Reasons, e.g. generating Reasons for Nvidia GPU Xid errors in dmesg log.

Close #1067

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jessehu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jessehu
Once this PR has been reviewed and has the lgtm label, please assign random-liu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 11, 2025
@jessehu jessehu force-pushed the templating-reason branch from 24e9230 to 411a1ba Compare June 12, 2025 07:42
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 12, 2025
@hakman
Copy link
Member

hakman commented Jun 18, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2025
@jessehu
Copy link
Author

jessehu commented Jun 19, 2025

/retest

@jessehu
Copy link
Author

jessehu commented Jun 19, 2025

Thanks @hakman for review! Looks like pull-npd-e2e-test failed twice. Not sure if it's related to this PR ?
图片

@hakman
Copy link
Member

hakman commented Jun 21, 2025

Thanks @hakman for review! Looks like pull-npd-e2e-test failed twice. Not sure if it's related to this PR ?

Unrelated to the PR, please ignore.

@jessehu
Copy link
Author

jessehu commented Jun 22, 2025

/retest

@jessehu
Copy link
Author

jessehu commented Jun 22, 2025 •
edited
Loading

Thanks @hakman. 1 test passed now but 2 tests still failed. Please take a look again.
图片

@jessehu
Copy link
Author

jessehu commented Jun 22, 2025

/retest

googs1025
googs1025 reviewed Jun 22, 2025
View reviewed changes
@jessehu
Copy link
Author

jessehu commented Jul 21, 2025

/retest

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 20, 2025
jessehu added 2 commits August 20, 2025 17:32
@jessehu
feat: Support configuring rule.Reason as a Sprintf format string
0fd1dff 
So we can define one templated Reason to generate many Reasons, e.g.
generating Reasons for Nvidia GPU Xid errors in dmesg log.
@jessehu
fix: Allow capturing groups in rule.Pattern with non-templated rule.R…
50016aa 
…eason
@jessehu jessehu force-pushed the templating-reason branch from ea452dd to 50016aa Compare August 20, 2025 09:33
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 20, 2025
@jessehu
Copy link
Author

jessehu commented Aug 20, 2025

hi @hakman would you mind review this PR again please? The pull-npd-e2e-test passed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman Awaiting requested review from hakman

@mmiranda96 mmiranda96 Awaiting requested review from mmiranda96

1 more reviewer

@googs1025 googs1025 googs1025 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposal: Support configuring rule.Reason as a Sprintf format string

4 participants

@jessehu @k8s-ci-robot @hakman @googs1025