-
Notifications
You must be signed in to change notification settings - Fork 523
kubelet.spec: Remove deps: conntrack*/iproute*/ethtool #4106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @travier! |
Hi @travier. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
CC @danwinship for confirmation. |
Yeah, this is true. You can remove the |
/ok-to-test |
/assign @xmudrii @mbianchidev |
According to [1] & [2], the kubelet is no longer relying on the following binaries: - conntrack since Kubernetes 1.24. - iproute / iproute2 - ethtool Thus drop the dependencies. [1] coreos/rhel-coreos-config#42 [2] kubernetes#4106
d1bca87
to
d2a7ae3
Compare
Thanks, updated. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: travier, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Greetings. I help maintain the Kubernete spec files for the Fedora repository. Would this change be for 1.34 only or can it also be applied to 1.33 and earlier? thank you |
I believe it applies back to 1.24 |
@danwinship - Thank you! |
kubelet.spec: Remove deps: conntrack*/iproute*/ethtool
According to [1] & [2], the kubelet is no longer relying on the
following binaries:
Thus drop the dependencies.
[1] coreos/rhel-coreos-config#42
[2] #4106
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Remove a dependency on a package that is no longer used.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?