Skip to content

Conversation

travier
Copy link
Contributor

@travier travier commented Sep 4, 2025

kubelet.spec: Remove deps: conntrack*/iproute*/ethtool

According to [1] & [2], the kubelet is no longer relying on the
following binaries:

  • conntrack since Kubernetes 1.24.
  • iproute / iproute2
  • ethtool

Thus drop the dependencies.

[1] coreos/rhel-coreos-config#42
[2] #4106

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove a dependency on a package that is no longer used.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove the dependency on conntrack and conntrack-tools for the kubelet package.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Sep 4, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @travier!

It looks like this is your first PR to kubernetes/release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @travier. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2025
@travier
Copy link
Contributor Author

travier commented Sep 4, 2025

CC @danwinship for confirmation.

@danwinship
Copy link
Contributor

Yeah, this is true.

You can remove the iproute/iproute2 and ethtool packages too. Those would have been needed for the old kubenet networking, but are not used by present-day kubelet.

@cpanato
Copy link
Member

cpanato commented Sep 5, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2025
@cpanato
Copy link
Member

cpanato commented Sep 5, 2025

/assign @xmudrii @mbianchidev

According to [1] & [2], the kubelet is no longer relying on the
following binaries:
- conntrack since Kubernetes 1.24.
- iproute / iproute2
- ethtool

Thus drop the dependencies.

[1] coreos/rhel-coreos-config#42
[2] kubernetes#4106
@travier travier force-pushed the master-drop-conntrack branch from d1bca87 to d2a7ae3 Compare September 6, 2025 11:38
@travier travier changed the title kubelet.spec: Remove conntrack(-tools) dependencies kubelet.spec: Remove deps: conntrack*/iproute*/ethtool Sep 6, 2025
@travier
Copy link
Contributor Author

travier commented Sep 6, 2025

You can remove the iproute/iproute2 and ethtool packages too. Those would have been needed for the old kubenet networking, but are not used by present-day kubelet.

Thanks, updated.

@mbianchidev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2025
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: travier, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7cc7d3e into kubernetes:master Sep 18, 2025
11 checks passed
@travier travier deleted the master-drop-conntrack branch September 18, 2025 18:07
@buckaroogeek
Copy link

Greetings. I help maintain the Kubernete spec files for the Fedora repository. Would this change be for 1.34 only or can it also be applied to 1.33 and earlier?

thank you

@danwinship
Copy link
Contributor

I believe it applies back to 1.24

@buckaroogeek
Copy link

@danwinship - Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants