Skip to content

Use timeout for pool connections#297

Merged
matthyx merged 1 commit intomainfrom
lock-detection
Mar 19, 2026
Merged

Use timeout for pool connections#297
matthyx merged 1 commit intomainfrom
lock-detection

Conversation

@matthyx
Copy link
Contributor

@matthyx matthyx commented Mar 16, 2026

Introduce poolContext helper and poolTimeout (1m); replace context.Background() with timed contexts when taking connections from the pool

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Warning

Rate limit exceeded

@matthyx has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 51 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bb4942aa-2a1b-46d5-bec1-ebf036792a34

📥 Commits

Reviewing files that changed from the base of the PR and between a10837d and 0e18534.

📒 Files selected for processing (1)
  • pkg/registry/file/storage.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lock-detection
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Introduce poolContext helper and poolTimeout (1m); replace
context.Background() with timed contexts when taking connections from
the pool

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@github-actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: failure

@matthyx matthyx moved this to WIP in KS PRs tracking Mar 17, 2026
@matthyx matthyx merged commit 14b200f into main Mar 19, 2026
7 checks passed
@matthyx matthyx deleted the lock-detection branch March 19, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: WIP

Development

Successfully merging this pull request may close these issues.

1 participant