Conversation
Signed-off-by: Ken Sipe <kensipe@gmail.com>
| status: | ||
| phase: Running | ||
|
|
||
| # confirms that kudo is running |
There was a problem hiding this comment.
Why is it necessary to check this here?
There was a problem hiding this comment.
I also thought that this PR removed this assertion in favor of kudo init ... --wait
There was a problem hiding this comment.
it makes the test more portal IMO... yes we should have a kudo init --wait. This fails fast if that wasn't done.. and I see these tests as something we may point users to... that may run them...
There was a problem hiding this comment.
I mean, we don't wait for KUDO this way for other operators tests today (because we already kudo init --wait) so I'd rather stay consistent right now and remove this. The inconsistency concern is IMO bigger than portability one.
There was a problem hiding this comment.
I agree with @zen-dog here - This is testing something that should be ensured globally not in each test. If we have this here, it will be copied to other tests and we end up with having this step duplicated everywhere.
We had this in the kudo e2e tests as well, I was glad we could remove it there.
zmalik
left a comment
zmalik
left a comment
There was a problem hiding this comment.
the intention here isn't not to run these tests with each PR but in a later iteration, we can work on when to run these tests and how to optimize running tests only for operator which is being changed.
I would like to see at least a weekly build or nightly with all the tests present in this repository, otherwise, we will have only broken tests with time. I will add this as a topic for the next community meeting
| @@ -0,0 +1,15 @@ | |||
| apiVersion: v1 | |||
| binaryData: | |||
There was a problem hiding this comment.
I don't think we need to check the exact content of the config map. Its presence along with the name: cowsayinstance.deploy.main.genfiles.genwww.indexhtml should be enough.
There was a problem hiding this comment.
yep... totally makes sense... removed
Signed-off-by: Ken Sipe <kensipe@gmail.com>
ANeumann82
left a comment
ANeumann82
left a comment
There was a problem hiding this comment.
lgtm, although I would prefer to not have the kudo assert as the first step.
| status: | ||
| phase: Running | ||
|
|
||
| # confirms that kudo is running |
There was a problem hiding this comment.
I agree with @zen-dog here - This is testing something that should be ensured globally not in each test. If we have this here, it will be copied to other tests and we end up with having this step duplicated everywhere.
We had this in the kudo e2e tests as well, I was glad we could remove it there.
5 participants
Signed-off-by: Ken Sipe kensipe@gmail.com