Feat/add assignee autocomplete #123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+22
to
+29
| const response = await fetch(`http://localhost:8000/tasks/${taskId}`, { | ||
| method: "PUT", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| Authorization: `Bearer ${GITHUB_TOKEN}`, | ||
| }, | ||
| body: JSON.stringify({ assignee_user_id: assignedUserId }), | ||
| }); |
Check failure
Code scanning / CodeQL
Server-side request forgery Critical
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To fix the SSRF vulnerability, we need to validate and sanitize the taskId parameter before using it in the URL. Specifically:
- Restrict the format of
taskId: Ensure thattaskIdadheres to a predefined format (e.g., alphanumeric or UUID) to prevent malicious input. - Use an allow-list: If possible, validate
taskIdagainst an allow-list of known valid task IDs. - Avoid direct concatenation: Construct the URL using safe methods that prevent injection or path traversal.
The best approach here is to validate taskId using a regular expression to ensure it conforms to a safe format (e.g., alphanumeric or UUID). This ensures that only legitimate task IDs are used in the request.
Suggested changeset
1
app/api/update-task/route.ts
| @@ -6,5 +6,6 @@ | ||
|
|
||
| if (!taskId || !assignedUserId) { | ||
| const taskIdRegex = /^[a-zA-Z0-9_-]+$/; // Allow alphanumeric, underscores, and hyphens | ||
| if (!taskId || !assignedUserId || !taskIdRegex.test(taskId)) { | ||
| return NextResponse.json( | ||
| { error: "Missing required fields" }, | ||
| { error: "Invalid or missing required fields" }, | ||
| { status: 400 }, | ||
| @@ -21,3 +22,3 @@ | ||
|
|
||
| const response = await fetch(`http://localhost:8000/tasks/${taskId}`, { | ||
| const response = await fetch(`http://localhost:8000/tasks/${encodeURIComponent(taskId)}`, { | ||
| method: "PUT", |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.