fix: RAII socket cleanup and hardened daemon shutdown#23
Merged
Conversation
- Add SocketCleanupGuard to remove the Unix socket on drop, preventing stale sockets from blocking future daemon starts after early exits - Harden send_shutdown_request with SIGTERM/SIGKILL fallback when the socket is unreachable but the daemon process is still alive
jleni
force-pushed
the
fix/socket-cleanup-guard
branch
from
d4e6f20 to
9f05592
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server_mainexits early (panic,?bail), preventing stale sockets from blocking future daemon starts.send_shutdown_requestnow falls back to SIGTERM → SIGKILL via the coordinator PID when the socket is unreachable but the daemon process is still alive.Test plan
kache daemon stopworks when daemon is healthykache daemon stoprecovers when socket is stale but process is alive