Skip to content

Automate Start/Stop on ContainerFixture when using [ClassDataSource<>] #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Automate Start/Stop on ContainerFixture when using [ClassDataSource<>] #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions test/Kurrent.Replicator.Tests/ChaserCheckpointSeedingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ public ChaserCheckpointSeedingTests(ContainerFixture fixture) {
.ForContext<ChaserCheckpointSeedingTests>();
}

[Before(Test)]
public async Task Start() => await _fixture.StartContainers();

[After(Test)]
public async Task Stop() => await _fixture.StopContainers();

[Test]
public async Task Verify() {
var v5DataPath = _fixture.V5DataPath;
Expand Down
6 changes: 0 additions & 6 deletions test/Kurrent.Replicator.Tests/CustomPartitionerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@ public ValuePartitionerTests(ContainerFixture fixture) {
.ForContext<ValuePartitionerTests>();
}

[Before(Test)]
public async Task Start() => await _fixture.StartContainers();

[After(Test)]
public async Task Stop() => await _fixture.StopContainers();

[Test]
public async Task ShouldKeepOrderWithinPartition() {
var checkpointStore = new CheckpointStore();
Expand Down
7 changes: 4 additions & 3 deletions test/Kurrent.Replicator.Tests/Fixtures/ContainerFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,16 @@
using EventStore.Client;
using EventStore.ClientAPI;
using Testcontainers.EventStoreDb;
using TUnit.Core.Interfaces;

namespace Kurrent.Replicator.Tests.Fixtures;

public class ContainerFixture {
public class ContainerFixture : IAsyncInitializer, IAsyncDisposable {
EventStoreDbContainer _kurrentDbContainer;
IContainer _eventStoreContainer;
public DirectoryInfo V5DataPath { get; private set; }

public async Task StartContainers() {
public async Task InitializeAsync() {
V5DataPath = Directory.CreateTempSubdirectory();
_kurrentDbContainer = BuildV23Container();
_eventStoreContainer = BuildV5Container(V5DataPath);
Expand All @@ -21,7 +22,7 @@ public async Task StartContainers() {
await Task.Delay(TimeSpan.FromSeconds(2)); // give it some time to spin up
}

public async Task StopContainers() {
public async ValueTask DisposeAsync() {
await Task.WhenAll(_kurrentDbContainer.StopAsync(), _eventStoreContainer.StopAsync());
await _eventStoreContainer.DisposeAsync();
await _kurrentDbContainer.DisposeAsync();
Expand Down