Interval exception detect when modify the lower or the upper property on an exist interval instance#48
Open
Taktoshi wants to merge 12 commits intokvesteri:masterfrom
Open
Interval exception detect when modify the lower or the upper property on an exist interval instance#48Taktoshi wants to merge 12 commits intokvesteri:masterfrom
Taktoshi wants to merge 12 commits intokvesteri:masterfrom
Conversation
…exist interval instance.
before fixing:
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
IntInterval('[3, 2]')
after fixing:
…exist interval instance.
before fixing:
>>> interval = IntInterval([1, 2])
>>> interval
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
IntInterval('[3, 2]')
after fixing:
>>> interval = IntInterval([1, 2])
>>> interval
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
it will raise the RangeBoundsException:
intervals.exc.RangeBoundsException: Min value 3 is bigger than max value 2.
…exist interval instance.
before fixing:
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
IntInterval('[3, 2]')
after fixing:
>>> interval = IntInterval([1, 2])
>>> interval
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
it will raise the RangeBoundsException:
intervals.exc.RangeBoundsException: Min value 3 is bigger than max value 2.
kvesteri
requested changes
Jan 22, 2020
intervals/interval.py
Outdated
| isinstance(arg, self.type) or | ||
| isinstance(arg, type(self)) or | ||
| arg == inf or arg == -inf | ||
| isinstance(arg, list) or |
Owner
There was a problem hiding this comment.
Please remove this and all similar style changes where you add extra indents.
Author
There was a problem hiding this comment.
I have revised all that changes.
kvesteri
requested changes
Jan 22, 2020
| @mark.parametrize( | ||
| ('constructor', 'number_range', 'bad_upper'), | ||
| ( | ||
| (IntInterval, (1, 2), 0), |
Owner
There was a problem hiding this comment.
Use the indentation of 4 spaces not 8.
Author
There was a problem hiding this comment.
The indentation has been revised to 4.
Owner
There was a problem hiding this comment.
There are still lines with indentation of 8 not 4
Author
There was a problem hiding this comment.
OK, I will check again and change them.
…y on an exist interval instance.
before fixing:
>>> interval = IntInterval([1, 2])
>>> interval
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
IntInterval('[3, 2]')
after fixing:
>>> interval = IntInterval([1, 2])
>>> interval
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
it will raise the RangeBoundsException:
intervals.exc.RangeBoundsException: Min value 3 is bigger than max value 2.
…y on an exist interval instance.
before fixing:
>>> interval = IntInterval([1, 2])
>>> interval
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
IntInterval('[3, 2]')
after fixing:
>>> interval = IntInterval([1, 2])
>>> interval
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
it will raise the RangeBoundsException:
intervals.exc.RangeBoundsException: Min value 3 is bigger than max value 2.
…y on an exist interval instance.
before fixing:
>>> interval = IntInterval([1, 2])
>>> interval
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
IntInterval('[3, 2]')
after fixing:
>>> interval = IntInterval([1, 2])
>>> interval
IntInterval('[1, 2]')
>>> interval.lower = 3
>>> interval
it will raise the RangeBoundsException:
intervals.exc.RangeBoundsException: Min value 3 is bigger than max value 2.
|
@easybase Can I suggest you to have a look at https://github.com/AlexandreDecan/portion ? It's a Python library providing data structure and operations for intervals (atomic and interval sets). And we will be happy to accept pull requests, even the ones that do not comply style-wise ;-) Apologies, it's a bit of publicity for another project, but this repository does not seem to be really maintained anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bug of range exception detection when change the lower or the upper property. Add 12 new tests in test_initialization.py named class TestIntervalChanging.
before fixing:
IntInterval('[1, 2]')
IntInterval('[3, 2]')
after fixing:
IntInterval('[1, 2]')
it will raise the RangeBoundsException:
intervals.exc.RangeBoundsException: Min value 3 is bigger than max value 2.
Update the .travis.yml because the python3.3 can not download. So I change the archive for Trusty.