avoid duplicate nameserver entries in resolv.conf#2
Open
thechile wants to merge 1 commit intokvz:masterfrom
Open
avoid duplicate nameserver entries in resolv.conf#2thechile wants to merge 1 commit intokvz:masterfrom
thechile wants to merge 1 commit intokvz:masterfrom
Conversation
currently the deemed best nameserver denoted by "use_server" will occur twice in the resolv.conf output which isn't ideal and in some circumstances could incur delayed lookups if it were to fail before the next cronjob to test for availability. Proposed change ensures each nameserver exists only once.
Owner
|
Thanks for the patch but |
Author
|
http://www.tldp.org/LDP/abs/html/ops.html gives example of the += as a numeric variable operator with a footnote http://www.tldp.org/LDP/abs/html/ops.html#FTN.AEN3900 saying it can also be used as string concatenation.. as used in the patch. |
Owner
|
Looks like it. But only as of bash 3.1. For the sake for portability I think I'd prefer |
Author
|
ok, sounds good. Look forward to using the script soon. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently the deemed best nameserver denoted by "use_server" will occur twice in the resolv.conf output which isn't ideal and in some circumstances could incur delayed lookups if it were to fail before the next cronjob to test for availability.
Proposed change ensures each nameserver exists only once.