masterでは Rails Guide のファイル形式と保存場所が移動しているのを対応 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 155cd5e the number_helpers were moved into AS all the tests were copied over but the tests in AP were not deleted. This is confusing. I removed all duplicated tests and reorganized the tests in AP to only test the functionality, that is added in AP.
* use 1.9 style hash syntax * don't use brances on assert_equal * prefere " over '
…ests Remove duplicated number_helper tests in AP. They are already in AS. With 155cd5e the number_helpers were moved into AS all the tests were copied over but the tests in AP were not deleted. This is confusing. This removes all duplicated tests and reorganized the tests in AP to only test the functionality, that is added in AP. Also cleanup some of the number helper tests.
Fix calculation of db_runtime property in ActiveRecord::Railties::ControllerRuntime#cleanup_view_runtime. Previously, after raising ActionView::MissingTemplate, db_runtime was not populated. Closes #9218, Fixes #9215. Conflicts: activerecord/CHANGELOG.md
Closes #9466.
Passing `format: true` used to override the constraints: { format: /json/ }
with `/.+/`. This patch only sets the format if there is no constraint present.
Keep in sync with 3-2-stable.
`format: true` does not override existing format constraints.
Closes #9480. We use `TableDefinition` for `#create_table` and `Table` for `#change_table`. The PostgreSQL sepcifc types were only defined on `TableDefinition` so I also added them to `Table`.
Support PostgreSQL specific column types when using `change_table`. We use `TableDefinition` for `#create_table` and `Table` for `#change_table`. The PostgreSQL sepcific types were only defined on `TableDefinition` so they needed to be added to `Table` as well.
…thin mounted engine
Fix for #9360 content_for regression
[ci skip]
Wrong exception is occured when raising no translatable exception Closes #8617
[ci skip]
there are just the same description about accepts_nested_attributes [ci skip]
clarify that the contents of the block is expected to return a string. the previous example executed puts and the initializer got nothing. also, made it consistent with the single-line example to be more clear as to what's going on
…h fixing few more typos
…r available at the previous location
First version Japanese getting_start.md
Bug fix getting_started.md.trans Add Original _license.html.erb Add Original layout.html.erb
Able run [rake guides:generate GUIDES_LANGUAGE=ja-JP]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails Guides は和訳されないかなー、と思ってこのリポジトリをみつました。
いろいろ翻訳するためのセッティングがされているようだったので、そのまま生かせるように lifo/docrails@814c9875ec4cf01e1348d1ab1c9d12eee5a9adac をマージした上で ja-JP ディレクトリの移動と markdown への対応をしてみました。
あとは rake diff をみながらなおしていけたらと。