Added two factor authentication. Fixed storing and reusing SID.#42
Open
andriinuts wants to merge 1 commit intokwent:masterfrom
Open
Added two factor authentication. Fixed storing and reusing SID.#42andriinuts wants to merge 1 commit intokwent:masterfrom
andriinuts wants to merge 1 commit intokwent:masterfrom
Conversation
Author
|
Hi @kwent, please take a look when you will have a minute. |
|
Will these changes be accepted? |
Owner
|
@andriinuts Sorry for the delay! Looks like there is some merge conflicts now. But i'll be happy to see this feature land for sure ! ( Maybe also separate session SID reuse in another commit to keep things atomic.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otp_codeparam to login for two-factor authentication (otplibis using for generating auth code).sessionName.