Skip to content

added per request cache time #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added per request cache time #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/apicache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,16 @@ function ApiCache() {
return defaultDuration
}

this.getDuration = function(duration) {
/**
* Function that parses cache duration string to milliseconds
* Can be overriden with custom logic depending on request and response
* Sic! Use "appendKey" option to generate custom cache key for this case!
* @param {string|number} duration
* @param {Object} req Express request
* @param {Object} res Express response
* @returns {number} cache time in ms
*/
this.getDuration = function(duration, req, res) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmtrpro You're adding the params to the signature, but not using them in any way... am I missing something?

return parseDuration(duration, globalOptions.defaultDuration)
}

Expand All @@ -414,7 +423,6 @@ function ApiCache() {
}

this.middleware = function cache(strDuration, middlewareToggle, localOptions) {
var duration = instance.getDuration(strDuration)
var opt = {}

middlewareOptions.push({
Expand Down Expand Up @@ -591,6 +599,8 @@ function ApiCache() {
performanceArray.push(perf)

var cache = function(req, res, next) {
var duration = instance.getDuration(strDuration, req, res)

function bypass() {
debug('bypass detected, skipping cache.')
return next()
Expand Down