Stop using numpy type aliases that were deprecated in 1.20 and later removed#81
Open
musicinmybrain wants to merge 3 commits intokwikteam:masterfrom
Open
Stop using numpy type aliases that were deprecated in 1.20 and later removed#81musicinmybrain wants to merge 3 commits intokwikteam:masterfrom
musicinmybrain wants to merge 3 commits intokwikteam:masterfrom
Conversation
It was just an alias for the built-in object, so use that instead.
It was just an alias for the built-in int, so use that instead.
6bef820 to
af32fe7
Compare
In older numpy releases, numpy.bool was the same as Python bool. This was deprecated in 1.20 and later removed for 1.x, then the name numpy.bool was reintroduced in numpy 2.x as an alias for numpy.bool_, a Boolean value stored as a byte. By using numpy.bool_, we get the same data type on all Python versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The types
np.objectandnp.intwere just aliases for the built-inobjectandint, respectively, so use those instead.In older numpy releases,
numpy.boolwas the same as Pythonbool. This was deprecated in 1.20 and later removed for 1.x, then the namenumpy.boolwas reintroduced in numpy 2.x as an alias fornumpy.bool_, a Boolean value stored as a byte. By usingnumpy.bool_everywhere, we get the same data type on all Python versions.Fixes:
(Only on numpy 1.x;
numpy.boolworks on 2.x, but with a different meaning):