Test/lint baseline#43
Open
sjswerdloff wants to merge 3 commits intokyegomez:mainfrom
Open
Conversation
These two files were the only ones not conforming to the project's own black configuration (line-length=88, target-version=py310).
Runs on push to main and PRs: - black --check (formatting) - ruff check (linting) - pytest (tests) Uses Poetry (matching pyproject.toml build-system) on Python 3.10 and 3.12.
torch 2.11.0 depends on triton 3.6.0 which requires Python <3.15. The previous range (>=3.10,<4.0) caused Poetry dependency resolution to fail because it couldn't guarantee compatibility for Python >=3.15.
|
Hi, Severity: informational | Category: maintainability How to fix: Align classifiers with version range Agent prompt to fix - you can give this to your LLM of choice:
Qodo code review - free for open-source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI to check formatting (black) and linting (ruff), using poetry per contents of pyproject.toml.
Testing is commented out (see PR #42).
Adjusting python version range to avoid clashing with triton requirements (so poetry will be able to resolve).