Fixes: Access Token in Persistent Storage is removed on hard refresh. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cess token when none is returned - i.e. before its been used (devise)
Author
|
Hey maintainers, just noting that jest fails currently. We dont seem to have TS interface testing. Main point of contention in auth.test.ts is |
This was referenced Aug 6, 2018
keymastervn
added a commit
to keymastervn/redux-token-auth
that referenced
this pull request
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in my approach here - #45 this PR makes sure that the auth token keys are not removed from localStorage when they aren't received (i.e. when (i.e. before first use and before they expire)