Skip to content

L2ps simplified #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tcsenpai wants to merge 65 commits into
base: testnet
Choose a base branch
from

ignored

330ae8a
Select commit
Loading
Failed to load commit list.
Open

L2ps simplified #495

ignored
330ae8a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Dec 6, 2025 in 32s

Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 538 in src/libs/blockchain/routines/Sync.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEwHduZKUq2z38AG&open=AZruYEwHduZKUq2z38AG&pullRequest=495

Check warning on line 85 in src/features/InstantMessagingProtocol/signalingServer/signalingServer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'offlineMessageCounts' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEyfduZKUq2z38Au&open=AZruYEyfduZKUq2z38Au&pullRequest=495

Check warning on line 29 in src/libs/network/routines/transactions/handleL2PS.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEqQduZKUq2z37_q&open=AZruYEqQduZKUq2z37_q&pullRequest=495

Check warning on line 375 in src/libs/l2ps/parallelNetworks.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYExQduZKUq2z38Ah&open=AZruYExQduZKUq2z38Ah&pullRequest=495

Check warning on line 19 in src/libs/network/endpointHandlers.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'@kynesyslabs/demosdk/types' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEvXduZKUq2z37__&open=AZruYEvXduZKUq2z37__&pullRequest=495

Check warning on line 142 in src/libs/l2ps/L2PSConcurrentSync.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.at(…)` over `[….length - index]`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEw3duZKUq2z38AT&open=AZruYEw3duZKUq2z38AT&pullRequest=495

Check failure on line 308 in src/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEzLduZKUq2z38A6&open=AZruYEzLduZKUq2z38A6&pullRequest=495

Check warning on line 274 in src/libs/blockchain/l2ps_mempool.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEwVduZKUq2z38AL&open=AZruYEwVduZKUq2z38AL&pullRequest=495

Check warning on line 238 in src/libs/network/dtr/relayRetryService.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEu4duZKUq2z37_9&open=AZruYEu4duZKUq2z37_9&pullRequest=495

Check warning on line 502 in src/libs/network/manageNodeCall.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEsHduZKUq2z37_3&open=AZruYEsHduZKUq2z37_3&pullRequest=495

Check warning on line 36 in src/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'./libs/blockchain/chain' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEzLduZKUq2z38A5&open=AZruYEzLduZKUq2z38A5&pullRequest=495

Check warning on line 230 in src/libs/l2ps/L2PSConcurrentSync.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'If' statement should not be the only statement in 'else' block 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEw3duZKUq2z38AU&open=AZruYEw3duZKUq2z38AU&pullRequest=495

Check warning on line 29 in src/libs/network/manageNodeCall.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'uint8ArrayToHex'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEsHduZKUq2z37_y&open=AZruYEsHduZKUq2z37_y&pullRequest=495

Check warning on line 25 in src/libs/blockchain/l2ps_hashes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this public static property readonly. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEwgduZKUq2z38AO&open=AZruYEwgduZKUq2z38AO&pullRequest=495

Check warning on line 261 in src/libs/blockchain/l2ps_mempool.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEwVduZKUq2z38AK&open=AZruYEwVduZKUq2z38AK&pullRequest=495

Check warning on line 32 in src/libs/network/manageNodeCall.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'../blockchain/mempool_v2' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEsHduZKUq2z37_0&open=AZruYEsHduZKUq2z37_0&pullRequest=495

Check warning on line 6 in src/libs/l2ps/parallelNetworks.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `node:fs` over `fs`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYExQduZKUq2z38AZ&open=AZruYExQduZKUq2z38AZ&pullRequest=495

Check warning on line 33 in src/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'@kynesyslabs/demosdk/encryption' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEzLduZKUq2z38A4&open=AZruYEzLduZKUq2z38A4&pullRequest=495

Check warning on line 215 in src/libs/blockchain/l2ps_hashes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Math.max()` to simplify ternary expressions. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEwgduZKUq2z38AP&open=AZruYEwgduZKUq2z38AP&pullRequest=495

Check warning on line 55 in src/libs/network/manageNodeCall.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of non-empty switch cases from 32 to at most 30. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEsHduZKUq2z37_1&open=AZruYEsHduZKUq2z37_1&pullRequest=495

Check warning on line 26 in src/libs/network/manageNodeCall.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'@kynesyslabs/demosdk/types' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEsHduZKUq2z37_v&open=AZruYEsHduZKUq2z37_v&pullRequest=495

Check warning on line 7 in src/libs/network/routines/transactions/handleL2PS.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'L2PS'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEqQduZKUq2z37_o&open=AZruYEqQduZKUq2z37_o&pullRequest=495

Check warning on line 24 in src/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'./libs/network/server_rpc' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEzLduZKUq2z38A0&open=AZruYEzLduZKUq2z38A0&pullRequest=495

Check failure on line 385 in src/libs/blockchain/routines/Sync.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEwHduZKUq2z38AF&open=AZruYEwHduZKUq2z38AF&pullRequest=495

Check warning on line 28 in src/libs/blockchain/l2ps_mempool.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this public static property readonly. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZruYEwVduZKUq2z38AH&open=AZruYEwVduZKUq2z38AH&pullRequest=495
View more details on SonarQubeCloud