Added a ci.yml file for continuous integration for Hallmark#13
Closed
Added a ci.yml file for continuous integration for Hallmark#13
Conversation
…g within this branch removed workflow_dispatch and ci_pipeline branch option
hfoote
requested changes
Nov 11, 2025
Member
hfoote
left a comment
hfoote
left a comment
There was a problem hiding this comment.
Looks good! Let's wait to merge this until after PR #11 is merged so there's a test suite for the CI action to run.
There's also one more follow-up step - you'll need to fix the formatting errors that ruff is complaining about as part of this PR so that the action passes.
…bout in the CI pipeline
Merging the branches because the remote branch was ahead of my local branch because we did worked on it earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Created a .yml file that contains the code for the continuous integration pipeline that helps to incorporate testing and formatting automatically in the hallmark code. Issue #12
Details
This .yml file consists of ruff for the linter to check the formatting and pytest to check if the code runs correctly. This file also ensures Python version 3.13 for continuous integration.
Testing
This .yml file is based off of another CI pipeline which is @hfoote's SnapAnalysis repo. We also manually tested it by adding a workflow_dispatch line in the .yml file on the ci_pipeline branch to check that it ran on the repo.
Follow-on
Some modifications would include adding more python versions when Hallmark is upgraded.