Updating main with (1) subclassed version of hallmark, (2) test suite and (3) ci pipeline#14
Merged
Updating main with (1) subclassed version of hallmark, (2) test suite and (3) ci pipeline#14
Conversation
… of pd Dataframe.
…Added a class method to parse function
…ubclassed version of hallmark
…re file (added .parse)
hfoote
requested changes
Nov 20, 2025
Member
hfoote
left a comment
There was a problem hiding this comment.
Looks great, nice work! CI is failing on a linter error - I've marked the line with a comment. That should be a quick fix and then we can merge this once CI passes.
One more follow-up task: We should add a unit test for ParaFrame.filter() soon. For now you've got this covered in the e2e test so I'm not worried about it.
tests/test_paraframe_e2e.py
Outdated
|
|
||
| # users want to filter files to see those with a = 0 or b = 10 | ||
| tuple_filter = pf(a=0, b=10) | ||
| # splitting columns with a=0 value and b=10 value to check that the correct number of |
Member
There was a problem hiding this comment.
Ruff is complaining that this line is too long, let's split this comment more evenly between the lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Testing
Follow On