Keep cursor item when opening a shulkerbox.#51
Open
DungeonDev wants to merge 1 commit intolMartin3:masterfrom
Open
Keep cursor item when opening a shulkerbox.#51DungeonDev wants to merge 1 commit intolMartin3:masterfrom
DungeonDev wants to merge 1 commit intolMartin3:masterfrom
Conversation
|
Wohooo, can't wait for this to be added so I can enable the feature again \o/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40 and fixes #49.
Keeps the current cursor item when opening a shulker, fixing the issue of cursor items being deleted when right-clicking a shulker in your inventory when not already having a shulker opened. Also has the added effect of making it easier to move stuff between shulkers.
The root cause of the issue is that player.openInventory deletes the cursor item if it exists. If you already have a shulker open, the player.closeInventory that happens earlier puts the cursor item in the player inventory, or drops it if there is no space.
This PR saves the cursor item and then sets the cursor item to null before closing the previous inventory, restoring cursor item back to the saved item after opening the shulker, making sure the call to closeInventory does not cause item duplication.