Fix relative path management to find pangenome.h5 file#54
Open
Fix relative path management to find pangenome.h5 file#54
Conversation
Enhanced path resolution by adding the `resolve_path` function to handle both absolute and relative paths robustly. Updated `check_tsv_sanity` to utilize this function for improved error handling and path validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior is to use the absolute path or the working directory relative path to find pangenome file. This is not the expected behavior describe in the documentation.
Example:
file tree
├── pangenome1.h5
├── pangenome2.h5
├── pangenomes
│ ├── pangenome3.h5
│ └── pangenome4.h5
└── pangenomes.tsv
pangenomes.tsv
pangenome1 /home/user/absolute/path/pangenome1.h5
pangenome2 pangenome2.h5
pangenome3 pangenomes/pangenome3.h5
pangenome4 /home/user/absolute/path/pangenome4.h5
This work if panorama is executed where pangenomes.tsv exist.
I Enhanced path resolution by adding the
resolve_pathfunction to handle both absolute and relative paths robustly.I Updated
check_tsv_sanityto utilize this function for improved error handling and path validation.