Open
Conversation
dimadeveatii
requested changes
Nov 12, 2019
dimadeveatii
requested changes
Nov 13, 2019
dimadeveatii
requested changes
Nov 14, 2019
Member
dimadeveatii
left a comment
dimadeveatii
left a comment
There was a problem hiding this comment.
Please cover with unit tests each internal file.
added 2 commits
November 14, 2019 10:52
dimadeveatii
requested changes
Nov 18, 2019
Member
dimadeveatii
left a comment
dimadeveatii
left a comment
There was a problem hiding this comment.
Please review unit tests, make sure you don't test internal state, only the public interface. Each unit test should have one assertion.
JohnDoePlusPlus
force-pushed
the
story/cache
branch
2 times, most recently
from
5c66cec to
20437a4
Compare
added 2 commits
November 18, 2019 16:43
…tors into story/cache
dimadeveatii
requested changes
Nov 19, 2019
dimadeveatii
approved these changes
Dec 2, 2019
Member
|
We should analyze the possibility to use the popular library lru-cache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.