Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1658 +/- ##
==========================================
+ Coverage 54.50% 54.63% +0.13%
==========================================
Files 443 447 +4
Lines 53782 54331 +549
==========================================
+ Hits 29313 29685 +372
- Misses 24469 24646 +177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I was not aware of these issues, and mac intel platforms remain supported. Could you tell me how to reproduce this error on a local intel mac? |
|
@nim65s On a mac intel I was not able to reproduce the segfault with a config that seems to me very close to the one used in nix ci. The only diff I see is the clang compiler version. This is my |
|
Ok, thanks for the test. |
|
NB: visp is build with clang 15 here, but not its dependencies |
|
Also, to reproduce locally, I can't double check on a macos right now, but
|
|
The CI show the same issue with Therefore, I guess this is an issue in a dependency as packaged by nix, and not in visp, so this PR can probably be closed. Thanks for the feedback ! |
… passing on macos-13 without segfault
Hello,
As found in NixOS/nixpkgs#403603 (comment), 57 tests out of 120 segfault on macos intel with nix.
This PR update the nix CI to test arm+intel / mac+ubuntu, to show it is still the case on master.
It probably should no be merged before those segfaults are sorted out :)
Or maybe this is already known, and mac intel platforms are considered out of scope / obsolete ?