Update the camera calibration app with the visualization of the lens distortion#1918
Open
s-trinh wants to merge 6 commits intolagadic:masterfrom
Open
Update the camera calibration app with the visualization of the lens distortion#1918s-trinh wants to merge 6 commits intolagadic:masterfrom
s-trinh wants to merge 6 commits intolagadic:masterfrom
Conversation
…ults for the camera calibration app.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1918 +/- ##
==========================================
- Coverage 48.68% 48.63% -0.06%
==========================================
Files 532 532
Lines 69293 69293
Branches 32403 32404 +1
==========================================
- Hits 33735 33700 -35
Misses 24976 24976
- Partials 10582 10617 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… lower extremities of the image.
…e image center (in green) and the camera principal point (in red) in the distortion displacement map image.
s-trinh
force-pushed
the
feat_calib_tools_displacement_map
branch
from
d38bc19 to
971d67a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chessboard calibration pattern is obsolete since the whole board must be detected and it does not allow to have points at the extremities of the image, which is crucial for correct lens distortion modelling.
This is what would give a classical images acquisition:
But this is what is fed to the calibration procedure:
With the first image in background, to check that the pattern occupancy is correct:
Some alternatives that are widely used are:
See also the DLR CalDe for advices about the procedure (e.g. oblique images are crucial, big calibration board in the image, ...):
Previous PR: #1063
Following are some results on ViSP and additional calibration images found on the Net.
./visp-calibrate-camera default-chessboard.cfg --save
./visp-calibrate-camera default-circles.cfg --save
Dataset 1
Canon 6D Lens Canon 35mm
Canon 6D Lens Canon Ultrasonic Macro 24-105mm
mosaics_reproj_err_with_dist_0000
mosaics_undist_0000
Canon PowerShot SX130
Canon 40D Lens Canon 28-90mm
GoPro
More distortion coefficients are needed.
mosaics_reproj_err_with_dist_0000
mosaics_undist_0000
Nikon D3200 Lens Nikon DX 18-105mm
mosaics_reproj_err_with_dist_0000
mosaics_undist_0000
OnePlus X
RaspberryPi