Skip to content

Conversation

@kovipu
Copy link
Member

@kovipu kovipu commented Sep 3, 2025

Summary of Changes

  • Liquidation bot
    • Update packages
    • Change data to the new multi loan format
    • Update reading events to work with p23
    • Update the liquidate API to match loan_manager
  • Scripts
    • Allow mock_oracle & set-price to work with Testnet

Considerations

Tästä tuli taas tämmönen mergele...

Related Issue

Please include a link to the relevant issue for context.

Author checklist

  1. Does your pull request change contract endpoint?
  • Yes, changes in loan_manager
    • Test was added in loan_manager.rs
  • Yes, changes in loan_pool
    • Test was added in loan_pool.rs
  • No
  1. Does your pull request demand a new deployment of contracts
  • Yes
  • No

@kovipu kovipu force-pushed the chore/liquidation-bot-p23 branch 3 times, most recently from 6d802f6 to 189dc0f Compare September 9, 2025 07:48
@kovipu kovipu force-pushed the chore/liquidation-bot-p23 branch from 189dc0f to b8f0452 Compare September 15, 2025 11:01
@kovipu kovipu force-pushed the chore/liquidation-bot-p23 branch from b8f0452 to fbec34f Compare September 16, 2025 11:15
@kovipu kovipu requested a review from Teolhyn September 23, 2025 13:55
Copy link
Member

@Teolhyn Teolhyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! There's an issue with the liquidation that is unrelated to your changes, but it should be fixed. I proposed a working fix in the comments. Not sure if it was caused by loose sequence rules in standalone network (then my bad :)) or if something changed in soroban client and how it handles sequence bumping.

@kovipu kovipu force-pushed the chore/liquidation-bot-p23 branch from 9e81771 to b471665 Compare September 24, 2025 14:18
@kovipu kovipu force-pushed the chore/liquidation-bot-p23 branch from b471665 to c7ca713 Compare September 24, 2025 14:19
@kovipu kovipu force-pushed the chore/liquidation-bot-p23 branch from ab83b4b to e77918f Compare September 25, 2025 06:56
@kovipu kovipu merged commit 6529a75 into main Sep 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants