feat: use shares instead of tokens for collateral to include interest #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teolhyn
force-pushed
the
feat/interest-from-collateral
branch
from
cca4a26 to
d811071
Compare
Teolhyn
force-pushed
the
feat/interest-from-collateral
branch
from
d811071 to
bc5353c
Compare
Teolhyn
force-pushed
the
feat/interest-from-collateral
branch
2 times, most recently
from
009f019 to
f234fdb
Compare
…iscule resolution
Teolhyn
force-pushed
the
feat/interest-from-collateral
branch
from
f234fdb to
91df76b
Compare
Teolhyn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Instead of loans storing the amount of tokens for collateral, convert them to pool shares instead. This way also the collateral gains interest over time without complex changes to architecture.
Considerations
This is VERY CRITICAL change that must be tested and reviewed thoroughly. As we now store shares, there's a need to change from shares->tokens and vice versa quite a bit, so we must be careful that correct parameters are used.
Related Issue
Author checklist
loan_managerloan_manager.rsloan_poolloan_pool.rs