Draft
Conversation
Contributes-To: lake-rs#93
Member
Author
|
Open points:
|
Member
Author
|
More precise open question: Should we even be doing this on BytesKeyEC2, or should that not be BytesP256ElemLen that would become a coordinate type? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes-To: #93
A first step is to go from a type alias (which the enum
CredentialKeycan make no guarantees on, because pub enum variant members are always pub) into a newtype.This is a breaking API change, so maybe we should prioritize doing the API change even when we can't validate, but this will need a bit more than this single commit.