CI TEST ONLY: Evaluate whether buffer sizes are independent#366
Draft
chrysn wants to merge 2 commits intolake-rs:mainfrom
Draft
CI TEST ONLY: Evaluate whether buffer sizes are independent#366chrysn wants to merge 2 commits intolake-rs:mainfrom
chrysn wants to merge 2 commits intolake-rs:mainfrom
Conversation
chrysn
force-pushed
the
probe-buffer-types
branch
2 times, most recently
from
8c029aa to
cb4d17b
Compare
If everyone used the right aliases everywhere, nothing will break...
chrysn
force-pushed
the
probe-buffer-types
branch
from
cb4d17b to
701bd7e
Compare
chrysn
force-pushed
the
probe-buffer-types
branch
from
701bd7e to
455ea46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by: #365 (so only look at last commit)
#363 only really "bites" once one starts to size the various buffers as they are needed. This commit does that: it alters all the buffers so their types are not aliases any more.
With the fixes already in #363, the local build passes -- let's see what I missed.