EXPERIMENTAL: defmt: Implement Format unconditionally#369
Draft
chrysn wants to merge 2 commits intolake-rs:mainfrom
Draft
EXPERIMENTAL: defmt: Implement Format unconditionally#369chrysn wants to merge 2 commits intolake-rs:mainfrom
chrysn wants to merge 2 commits intolake-rs:mainfrom
Conversation
Member
Author
|
The extra data defmt emits do not go well with the linker which the crates choose. This might get better with knurling-rs/defmt#878 (comment) over time; let's retry when that one is through. |
chrysn
force-pushed
the
unconditional-defmt
branch
from
7626d99 to
27e2d07
Compare
Member
Author
|
Funnily, using the hexencode-and-no-equals branch fixes things for Linux, but leaves them broken for Windows and breaks for MacOS; we'll know more when that defmt PR settles (and can then tell more easily whether it's the hex thing or my hack for getting rid of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This first iteration is mainly a test to see if we can do this unconditionally -- our CI builds Python binaries out of all those, so seeing it pass should be a good indication that indeed it's fine to implement defmt::Format even without having any linker script support.