Skip to content

Aes ccm 16 128 128#407

Open
WilliamTakeshi wants to merge 2 commits intolake-rs:mainfrom
WilliamTakeshi:aes-ccm-16-128-128
Open

Aes ccm 16 128 128#407
WilliamTakeshi wants to merge 2 commits intolake-rs:mainfrom
WilliamTakeshi:aes-ccm-16-128-128

Conversation

@WilliamTakeshi
Copy link
Contributor

@WilliamTakeshi WilliamTakeshi commented Feb 24, 2026

The PR #398 was getting to much crowded, so I decided to break in 2 parts.

This is the first part, where we make aes_ccm_encrypt_tag_8 generic over TAG_LEN. Since we only need TAG_LEN = 8 or 16, also a CcmTagLen bound is implemented.

@WilliamTakeshi WilliamTakeshi marked this pull request as ready for review February 24, 2026 12:15
Copy link
Member

@malishav malishav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @chrysn do you want to take a look?

}
match Tag::LEN {
8 => {
let tag = AesCcm16_64_128::new(key.into())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this var name tag?

}

16 => {
let tag = AesCcm16_128_128::new(key.into())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants