Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates the ZisK SDK by updating all ethrex dependencies to use the zisk_sdk branch and modifying the execution flow to skip execution when using ZisK as the backend (since ZisK executes during proving). The key change is converting execution_result from Result<Duration, eyre::Report> to Option<Result<Duration, eyre::Report>> to support cases where execution is not performed.
Key changes:
- Modified execution workflow to conditionally skip execution for ZisK backend due to MPI initialization constraints
- Added
has_error()helper method to centralize error checking logic - Updated all pattern matching and error handling to accommodate optional execution results
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/report.rs | Changed execution_result to Option<Result>, added has_error() method, updated all pattern matching for Slack messages, logging, benchmarks, and Display trait to handle None execution results |
| src/cli.rs | Added conditional execution skipping for ZisK backend in 4 locations (batch replay, block replay, custom L1 blocks, custom L2 blocks), refactored to avoid duplicate backend() calls, updated error checking to use has_error() |
| Cargo.toml | Updated all 19 ethrex dependency branches from "main" to "zisk_sdk" for consistent SDK integration |
| Cargo.lock | Added numerous ZisK-related dependencies (zisk-sdk, zisk-common, zisk-core, etc.) and supporting libraries (MPI, proofman, etc.) |
| .github/actions/install-zisk/action.yml | Updated environment variables for ZisK installation (added SETUP_KEY and ZISK_VERSION, removed GH_RUNNER) and added PATH configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
lambdaclass/ethrex#5404
Skips execution when using ZisK (ZisK executes before proving anyways)
Note: we require 0xPolygonHermez/zisk#674 for this to work. Don't merge until those changes are applied to ZisK.