Skip to content

chore(l1): use ZisK sdk#47

Open
xqft wants to merge 36 commits intomainfrom
zisk_sdk
Open

chore(l1): use ZisK sdk#47
xqft wants to merge 36 commits intomainfrom
zisk_sdk

Conversation

@xqft
Copy link
Copy Markdown
Contributor

@xqft xqft commented Nov 24, 2025

Motivation

lambdaclass/ethrex#5404

Skips execution when using ZisK (ZisK executes before proving anyways)

Note: we require 0xPolygonHermez/zisk#674 for this to work. Don't merge until those changes are applied to ZisK.

@xqft xqft changed the title chore(l2): use ZisK sdk chore(zisk): use ZisK sdk Nov 24, 2025
@github-actions github-actions bot removed the L2 label Nov 24, 2025
@xqft xqft changed the title chore(zisk): use ZisK sdk chore(l1): use ZisK sdk Nov 24, 2025
@github-actions github-actions bot added the L1 label Nov 24, 2025
@xqft xqft marked this pull request as ready for review November 24, 2025 14:43
Base automatically changed from add_support_for_zisk_zkvm to main November 26, 2025 16:50
Copilot AI review requested due to automatic review settings November 27, 2025 14:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates the ZisK SDK by updating all ethrex dependencies to use the zisk_sdk branch and modifying the execution flow to skip execution when using ZisK as the backend (since ZisK executes during proving). The key change is converting execution_result from Result<Duration, eyre::Report> to Option<Result<Duration, eyre::Report>> to support cases where execution is not performed.

Key changes:

  • Modified execution workflow to conditionally skip execution for ZisK backend due to MPI initialization constraints
  • Added has_error() helper method to centralize error checking logic
  • Updated all pattern matching and error handling to accommodate optional execution results

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/report.rs Changed execution_result to Option<Result>, added has_error() method, updated all pattern matching for Slack messages, logging, benchmarks, and Display trait to handle None execution results
src/cli.rs Added conditional execution skipping for ZisK backend in 4 locations (batch replay, block replay, custom L1 blocks, custom L2 blocks), refactored to avoid duplicate backend() calls, updated error checking to use has_error()
Cargo.toml Updated all 19 ethrex dependency branches from "main" to "zisk_sdk" for consistent SDK integration
Cargo.lock Added numerous ZisK-related dependencies (zisk-sdk, zisk-common, zisk-core, etc.) and supporting libraries (MPI, proofman, etc.)
.github/actions/install-zisk/action.yml Updated environment variables for ZisK installation (added SETUP_KEY and ZISK_VERSION, removed GH_RUNNER) and added PATH configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants