Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Pico backend as a new ZK-VM option for the L2 system, following the integration work done in the ethrex repository (PR #5440).
Key changes:
- Adds Pico as a supported backend alongside SP1, Risc0, ZisK, and OpenVM
- Updates all ethrex dependencies to use the "pico" branch instead of "main"
- Introduces new Pico-specific dependencies and Plonky3 libraries from brevis-network fork
- Adds CI/CD workflow support for building and testing with the Pico feature
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/cli.rs |
Adds Pico backend case to the ZKVM match statement and updates the error message to include Pico |
Cargo.toml |
Changes all ethrex dependency branches from "main" to "pico" and adds the pico feature flag |
Cargo.lock |
Updates dependency lock file with new Pico-related packages (pico-sdk, pico-vm, pico-derive, etc.) and Plonky3 libraries from brevis-network fork |
.github/workflows/pr-main.yaml |
Adds "pico" and "l2,pico" to the feature matrix and adds conditional logic to use nightly Rust for Pico builds |
.github/actions/install-pico/action.yml |
Defines a new composite action to install the Pico toolchain and CLI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support was added to ethrex in lambdaclass/ethrex#5440