Skip to content

chore(l1): preventing errors to propagate to spawned #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 4, 2025

Conversation

ElFantasma
Copy link
Contributor

@ElFantasma ElFantasma commented Jul 25, 2025

Motivation

Error lines in spawned logs were muted because there was a lot of spam regarding failed connections and handshakes. That was not safe as other important problems may get muted too.

Description

This PR handles the connection errors on handshake and initialization and logs a lower priority log line (debug) as it is pretty common.

It also reverts the log directive to mute spawned initialization errors.

it requires spawned 0.2.2.

Closes #3472

@github-actions github-actions bot added the L1 Ethereum client label Jul 25, 2025
Copy link

github-actions bot commented Jul 25, 2025

Lines of code report

Total lines added: 38
Total lines removed: 5
Total lines changed: 43

Detailed view
+-----------------------------------------------------------+-------+------+
| File                                                      | Lines | Diff |
+-----------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/initializers.rs                         | 297   | -5   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/l2/monitor/app.rs                           | 457   | +3   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_watcher.rs                  | 339   | +2   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/handshake.rs | 496   | +3   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/server.rs    | 846   | +30  |
+-----------------------------------------------------------+-------+------+

@ElFantasma ElFantasma marked this pull request as ready for review July 30, 2025 19:25
@ElFantasma ElFantasma requested a review from a team as a code owner July 30, 2025 19:25
Copy link
Contributor

@tomip01 tomip01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

Copy link
Contributor

@fedacking fedacking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments

@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Aug 4, 2025
@ElFantasma ElFantasma enabled auto-merge August 4, 2025 14:41
@ElFantasma ElFantasma added this pull request to the merge queue Aug 4, 2025
Merged via the queue into main with commit 49fde90 Aug 4, 2025
41 checks passed
@ElFantasma ElFantasma deleted the catch_init_errors_on_connection branch August 4, 2025 16:41
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L1 Ethereum client
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Prevent errors from propagating to spawned
4 participants