Use final state for teardown function
#37
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedacking
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
LGTM
with this solution we are only going through a teardown when everything works as expected, should we call the function with the initial state in case the init fails?
I don't think so, if init fails we may be in an inconsistent state, and the teardown function could be wrong.
MegaRedHand
reviewed
Jul 21, 2025
| }; | ||
|
|
||
| handle.cancellation_token().cancel(); | ||
| if let Err(err) = self.teardown(handle, state).await { | ||
| if let Err(err) = self.teardown(handle, final_state).await { |
There was a problem hiding this comment.
Should this also be run if main_loop fails?
There was a problem hiding this comment.
I'm still unsure as to if its "correct" or not to go through a teardown knowing that our state may be incorrect, maybe just going through this process in the happy case is right approach.
|
(Accidentally) solved by #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of our
teardownfunction would use the initial state of the GenServer, intead of the last state retrieved from the main loop, this PR fixes that.Note: with this solution we are only going through a
teardownwhen everything works as expected, should we call the function with the initial state in case theinitfails?