Skip to content

🍱 New organisms of Protein: uniprot, 2026-01#371

Merged
sunnyosun merged 11 commits intomainfrom
add_new_organisms_and_update
Apr 20, 2026
Merged

🍱 New organisms of Protein: uniprot, 2026-01#371
sunnyosun merged 11 commits intomainfrom
add_new_organisms_and_update

Conversation

@ishitajain9717
Copy link
Copy Markdown
Contributor

@ishitajain9717 ishitajain9717 commented Apr 20, 2026

Note: For an existing instance, please first run bt.core.sync_public_sources() to sync new sources!

Added support for the following organisms in Protein via bionty-assets:

  • "Rattus norvegicus"
  • "Canis lupus"
  • "Macaca fascicularis"
  • "Sus scrofa"
  • "Cricetulus griseus"
  • "Escherichia coli"
  • "Arabidopsis thaliana"
  • "Saccharomyces cerevisiae"
  • "Bos taurus"

Curated in transform: https://lamin.ai/laminlabs/bionty-assets/transform/Y0jzryYsJOeX0001

Changes in the python package:

  • Allow passing the scientific name of an organism (due to the ambiguity of common names from different sources)
  • source.name must match the organism keys in sources.yaml, be it common name or scientific name
  • always use lower case in organism keys in sources.yaml

Addresses:

Comment thread bionty/base/entities/_protein.py Outdated
organism: Literal["human", "mouse", "mouse-ear cress", "bovine", "dog", "chinese hamster", "e. coli", "long-tailed macaque", "saccharomyces cerevisiae s288c", "pig"] | None = None,
source: Literal["uniprot"] | None = None,
version: Literal["2026-01", "2024-03", "2023-03", "2023-02"] | None = None,
version: Literal["2026-01", "2024-03", "2023-03", "2023-02", "2026_04_10"] | None = None,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishitajain9717 The current version is 2026-01, see https://www.uniprot.org/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please note there's - not _ in the versions.

@sunnyosun
Copy link
Copy Markdown
Member

sunnyosun commented Apr 20, 2026

Reviewing this transform https://lamin.ai/laminlabs/bionty-assets/transform/Y0jzryYsJOeX0001:

  1. There are some duplications in the output artifacts, you added 8 organisms, which should correspond to 8 output artifacts, but there are 26 here. This seems to come from soft deletion of the previous transforms and artifacts:
    image
    image
    image
  2. The version should be 2026-01 (what you had was the download date), as the same format of the template. Also please note the - not _ in the version string.
  3. Please run ln.track() by passing project as the template; it's important that all outputs are labeled with the project.
  4. norway rat is missing from the new sources.

@ishitajain9717 I'll take care of this now so we can merge this PR. Also, a good PR title and description would be great 😊; I updated them.

@sunnyosun sunnyosun changed the title added the test file for updates organisms and change the source.yaml … New organisms of ontology: Protein, 2026-01 Apr 20, 2026
@sunnyosun sunnyosun linked an issue Apr 20, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

@github-actions github-actions Bot temporarily deployed to pull request April 20, 2026 11:41 Inactive
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishitajain9717 tests should go to test_protein.py, also you don't need to execute the function here.

@github-actions github-actions Bot temporarily deployed to pull request April 20, 2026 11:56 Inactive
@github-actions github-actions Bot temporarily deployed to pull request April 20, 2026 12:24 Inactive
@sunnyosun sunnyosun changed the title New organisms of ontology: Protein, 2026-01 New organisms of Uniprot: Protein, 2026-01 Apr 20, 2026
@sunnyosun sunnyosun changed the title New organisms of Uniprot: Protein, 2026-01 New organisms of Protein: uniprot, 2026-01 Apr 20, 2026
@github-actions github-actions Bot temporarily deployed to pull request April 20, 2026 12:32 Inactive
@github-actions github-actions Bot temporarily deployed to pull request April 20, 2026 14:16 Inactive
@sunnyosun sunnyosun merged commit 038ff88 into main Apr 20, 2026
10 of 11 checks passed
@sunnyosun sunnyosun deleted the add_new_organisms_and_update branch April 20, 2026 14:55
@falexwolf falexwolf changed the title New organisms of Protein: uniprot, 2026-01 🍱 New organisms of Protein: uniprot, 2026-01 Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bionty.Protein sources

2 participants