Open
Conversation
The existing implementation of `cache-manager` is not providing tiered priority caching benefit. This commit removes the `cache-manager` implementation.
ryanricard
force-pushed
the
fix/remove-cache-manager
branch
from
51c65e8 to
3980d45
Compare
Owner
|
Hi Ryan, Thank you for the pull request. I'll investigate further and see how it can be best optimized in a few weeks. Right now I'm just a little bit too busy with other projects and private live to work on this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @lammertw. I was reviewing this plugin and found it may not be providing the tiered priority caching benefits via
cache-managerthat you expect. You will find in thecache-managersource it is simply proxying the interface of your custom store (i.e.mongo_cache) without providing any in memory priority caching benefits (https://github.com/BryanDonovan/node-cache-manager/blob/master/lib/caching.js#L130). To leverage a tiered cache withcache-managercaching would need to be configured via its Multi Store api. This pull request removes the dependency of this plugin oncache-manageras it is not providing its intended value.Please let me know if I am wrong or my understanding of the
cache-managersource to be incorrect.