Members initialization in AssociationParameters#40
Open
cguebert wants to merge 1 commit intolamyj:masterfrom
Open
Members initialization in AssociationParameters#40cguebert wants to merge 1 commit intolamyj:masterfrom
cguebert wants to merge 1 commit intolamyj:masterfrom
Conversation
…here some members could have garbage values.
Owner
|
Sadly, I can't merge this yet: I still need to support Ubuntu 12.04 and its GCC 4.6, which does not have in-class initializers. I'll leave this PR open for now, since the official support (and hence Odil's support) will end at in March 2017. |
Contributor
Author
|
At least we should fix the bug of |
Owner
|
Initialization is fixed in b3d1518 while waiting for Ubuntu 12.04 to be end-of-life. |
Contributor
|
@lamyj do you think this one could be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are currently 3 constructors for AssociationParameters, but not all initialize all the class members.
We can factor using class member initializers.
Also, calling default constructors for members is not necessary.